Skip to content

Rename arg_iter to iter_instantiated #113801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2023
Merged

Rename arg_iter to iter_instantiated #113801

merged 1 commit into from
Jul 18, 2023

Conversation

compiler-errors
Copy link
Member

arg_iter doesn't make sense, and doesn't really indicate what it's doing (returning an iterator that substitutes instantiates its elements).

iter_instantiated_copied is kinda awkward but i don't really wanna bikeshed it.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@oli-obk
Copy link
Contributor

oli-obk commented Jul 17, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit 781b1042456e958a3676da69e3bdd36887ffd785 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2023
@bors
Copy link
Collaborator

bors commented Jul 17, 2023

☔ The latest upstream changes (presumably #113686) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the iter-instantiated branch from 781b104 to 05f6890 Compare July 17, 2023 21:04
@compiler-errors
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit 05f6890 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 17, 2023
@bors
Copy link
Collaborator

bors commented Jul 18, 2023

⌛ Testing commit 05f6890 with merge 6b9236e...

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6b9236e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2023
@bors bors merged commit 6b9236e into rust-lang:master Jul 18, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 18, 2023
@bors bors mentioned this pull request Jul 18, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6b9236e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.7%, -0.5%] 4
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.8% [-2.2%, -1.1%] 4
Improvements ✅
(secondary)		 -1.3% [-1.5%, -1.2%] 2
All ❌✅ (primary) -1.8% [-2.2%, -1.1%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 657.921s -> 658.29s (0.06%)

@compiler-errors compiler-errors deleted the iter-instantiated branch August 11, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @oli-obk @bors @rust-timer